netdev - RE: [PATCH v4 net-next 5/6] net: dsa: microchip: break KSZ9477 DSA driver into two files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN1PR11MB0446A944C5B1FE0112180F01ECAE0@SN1PR11MB0446.namprd11.prod.outlook.com>
Date:   Mon, 3 Dec 2018 20:44:36 +0000
From:   <Tristram.Ha@...rochip.com>
To:     <Stefan.Sorensen@...ctralink.com>
CC:     <netdev@...r.kernel.org>, <pavel@....cz>, <f.fainelli@...il.com>,
        <UNGLinuxDriver@...rochip.com>, <andrew@...n.ch>,
        <davem@...emloft.net>
Subject: RE: [PATCH v4 net-next 5/6] net: dsa: microchip: break KSZ9477 DSA
 driver into two files

> From: Sørensen, Stefan <Stefan.Sorensen@...ctralink.com>
> Sent: Monday, December 03, 2018 5:50 AM
> To: davem@...emloft.net; Tristram Ha - C24268
> <Tristram.Ha@...rochip.com>
> Cc: netdev@...r.kernel.org; pavel@....cz; f.fainelli@...il.com;
> UNGLinuxDriver <UNGLinuxDriver@...rochip.com>; andrew@...n.ch
> Subject: Re: [PATCH v4 net-next 5/6] net: dsa: microchip: break KSZ9477 DSA
> driver into two files
> 
> On Tue, 2018-11-20 at 15:55 -0800, Tristram.Ha@...rochip.com wrote:
> > From: Tristram Ha <Tristram.Ha@...rochip.com>
> >
> > Break KSZ9477 DSA driver into two files in preparation to add more
> > KSZ switch drivers.
> > Add common functions in ksz_common.h so that other KSZ switch drivers
> > can access code in ksz_common.c.
> > Add ksz_spi.h for common functions used by KSZ switch SPI drivers.
> 
> With this patch, the ethernet on my EVB-KSZ9477 is now completely non-
> functional, link is detected on the LAN ports, but no packets are
> forwarded to/from the CPU port.
> 
> Looking through the patch, it does much more than splitting up the
> existing code, e.g. the PORT_VLAN_MEMBERSHIP register is now written to
> - I suspect that change may be responsible for the problem.
> 

It is more likely the RGMII interface is not set properly.  There are upcoming
patches that address this issue.  The primary way to set RGMII delay is to set
phy-mode to "rgmii-txid" inside the device tree under the ksz9477 definition.
The chip can be set to MII/RMII with strap options, but there is no way to
change RGMII delay settings.

The patch will try to get the mode from hardware first.  When it is not set in
device tree this mode will be used.  When it is different from the one set a
warning will be displayed.  The one from device tree will be the one to use.

This will patch will support KSZ9893, a 3-port variant of KSZ9477.  It shares
most of the registers but has a different tail tag format, and uses a different
RGMII setting in the evaluation board.

Or do you use a different CPU port rather than the default port 6?