netdev - Re: [PATCH v4 net-next 5/6] net: dsa: microchip: break KSZ9477 DSA driver into two files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ba0a0c1eda2c3472aaf4a5606da0d5ca38d460b.camel@spectralink.com>
Date:   Mon, 3 Dec 2018 13:49:30 +0000
From:   Sørensen, Stefan 
        <Stefan.Sorensen@...ctralink.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "Tristram.Ha@...rochip.com" <Tristram.Ha@...rochip.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pavel@....cz" <pavel@....cz>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH v4 net-next 5/6] net: dsa: microchip: break KSZ9477 DSA
 driver into two files

On Tue, 2018-11-20 at 15:55 -0800, Tristram.Ha@...rochip.com wrote:
> From: Tristram Ha <Tristram.Ha@...rochip.com>
> 
> Break KSZ9477 DSA driver into two files in preparation to add more
> KSZ switch drivers.
> Add common functions in ksz_common.h so that other KSZ switch drivers
> can access code in ksz_common.c.
> Add ksz_spi.h for common functions used by KSZ switch SPI drivers.

With this patch, the ethernet on my EVB-KSZ9477 is now completely non-
functional, link is detected on the LAN ports, but no packets are
forwarded to/from the CPU port.

Looking through the patch, it does much more than splitting up the
existing code, e.g. the PORT_VLAN_MEMBERSHIP register is now written to
- I suspect that change may be responsible for the problem.


Stefan