netdev - Re: [PATCH v2 net] tun: remove skb access after netif_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181203.141110.1745473254554074270.davem@davemloft.net>
Date:   Mon, 03 Dec 2018 14:11:10 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     bhole_prashant_q7@....ntt.co.jp
Cc:     jasowang@...hat.com, mst@...hat.com, makita.toshiaki@....ntt.co.jp,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] tun: remove skb access after netif_receive_skb

From: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
Date: Mon,  3 Dec 2018 18:09:24 +0900

> In tun.c skb->len was accessed while doing stats accounting after a
> call to netif_receive_skb. We can not access skb after this call
> because buffers may be dropped.
> 
> The fix for this bug would be to store skb->len in local variable and
> then use it after netif_receive_skb(). IMO using xdp data size for
> accounting bytes will be better because input for tun_xdp_one() is
> xdp_buff.
> 
> Hence this patch:
> - fixes a bug by removing skb access after netif_receive_skb()
> - uses xdp data size for accounting bytes
 ...
> Fixes: 043d222f93ab ("tuntap: accept an array of XDP buffs through sendmsg()")
> Reviewed-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
> Acked-by: Jason Wang <jasowang@...hat.com>
> ---
> v1 -> v2:
> No change. Reposted due to patchwork status.

Applied, thanks.