netdev - Re: [Patch net] mlx5: check for malformed packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXCJikUcpV_y_nFo+CS6SCM+3bvMD7ryrY5bK292Z_KVg@mail.gmail.com>
Date:   Tue, 4 Dec 2018 12:17:09 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     saeedm@....mellanox.co.il
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [Patch net] mlx5: check for malformed packets

On Tue, Dec 4, 2018 at 11:28 AM Saeed Mahameed
<saeedm@....mellanox.co.il> wrote:
>
> We are against having inline keywords in c file,  so better if you
> move this function to a header file an force the inline keyword there.


Two points:

1. The existing code without my patch has inline keyword. Why
not move it from the beginning?

2. As I already mentioned, inline doesn't work with my patch,
__always_inline does.

Therefore, moving inline to a header doesn't make any difference.