netdev - Re: [PATCH bpf-next 1/7] mips: bpf: implement jitting of BPF_ALU | BPF_ARSH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8802b738-c0f3-1806-4c27-998b1a440df5@netronome.com>
Date:   Wed, 5 Dec 2018 11:07:38 +0000
From:   Jiong Wang <jiong.wang@...ronome.com>
To:     Paul Burton <paul.burton@...s.com>
Cc:     "daniel@...earbox.net" <daniel@...earbox.net>,
        "ast@...nel.org" <ast@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH bpf-next 1/7] mips: bpf: implement jitting of BPF_ALU |
 BPF_ARSH | BPF_X

On 05/12/2018 00:02, Paul Burton wrote:
> Hi Jiong,
>
> On Tue, Dec 04, 2018 at 03:55:16PM -0500, Jiong Wang wrote:
>> Jitting of BPF_K is supported already, but not BPF_X. This patch complete
>> the support for the latter on both MIPS and microMIPS.
>>
>> Cc: Paul Burton <paul.burton@...s.com>
>> Cc: linux-mips@...r.kernel.org
>> Signed-off-by: Jiong Wang <jiong.wang@...ronome.com>
>> ---
>>   arch/mips/include/asm/uasm.h      | 1 +
>>   arch/mips/include/uapi/asm/inst.h | 1 +
>>   arch/mips/mm/uasm-micromips.c     | 1 +
>>   arch/mips/mm/uasm-mips.c          | 1 +
>>   arch/mips/mm/uasm.c               | 9 +++++----
>>   arch/mips/net/ebpf_jit.c          | 4 ++++
>>   6 files changed, 13 insertions(+), 4 deletions(-)
> I don't seem to have been copied on the rest of the series, but this
> patch standalone looks good from a MIPS standpoint. If the series is
> going through the net tree (and again, I can't see whether that seems
> likely because I don't have the rest of the series) then:
>
>      Acked-by: Paul Burton <paul.burton@...s.com>
>
> If you want me to take this patch through the MIPS tree instead then let
> me know.

Hi Paul,

Thanks very much for the review. I'd like this set to go through net tree
that this feature could be enabled as a whole for all affected arches.

For the Cc, I was thinking the practice is to Cc people on patches of their
subsystems, but guess a better practice might be also Cc on the cover letter
so the background and affected code scope will be more clear.

I will do this in v2.

Regards,
Jiong