netdev - Re: [net-next 7/7] net/mlx5e: Improve ethtool private-flags code structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUt_5guB9agbTBDuCxVK+S8fMtqf4cCm_Lb3MXjpEk39A@mail.gmail.com>
Date:   Wed, 5 Dec 2018 11:28:12 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net-next 7/7] net/mlx5e: Improve ethtool private-flags code structure

Hello, Saeed

On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed <saeedm@...lanox.com> wrote:
>  static int mlx5e_handle_pflag(struct net_device *netdev,
>                               u32 wanted_flags,
> -                             enum mlx5e_priv_flag flag,
> -                             mlx5e_pflag_handler pflag_handler)
> +                             enum mlx5e_priv_flag flag)
>  {
...
>         if (err) {
>                 netdev_err(netdev, "%s private flag 0x%x failed err %d\n",
>                            enable ? "Enable" : "Disable", flag, err);

As flag is now a true enum, you probably don't want to print it out as hex
any more.

Thanks.