netdev - Re: [net-next 4/7] net/mlx5e: Refactor TIR configuration function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bb9805650fe0c8992673a5839c5e79530bc7b83.camel@mellanox.com>
Date:   Wed, 5 Dec 2018 23:47:27 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Aya Levin <ayal@...lanox.com>
Subject: Re: [net-next 4/7] net/mlx5e: Refactor TIR configuration function

On Wed, 2018-12-05 at 10:56 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> > +static const struct mlx5e_tirc_config
> > +tirc_default_config[MLX5E_NUM_INDIR_TIRS] = {
> 
> Is it okay to define an array in a header??? No link error???
> 
> I must be dumb...

Yes it is ok, no link error, each c file scope will get it's own copy.

but this is wasteful, will fix this in v2.

Thanks.