netdev - Re: [net-next 6/7] net/mlx5e: ethtool, Support user configuration for RX hash fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfa009669f589ccd042e641e409f1a7b829b1305.camel@mellanox.com>
Date:   Wed, 5 Dec 2018 23:47:50 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Aya Levin <ayal@...lanox.com>
Subject: Re: [net-next 6/7] net/mlx5e: ethtool, Support user configuration for
 RX hash fields

On Wed, 2018-12-05 at 11:19 -0800, Cong Wang wrote:
> Hello, Saeed
> 
> 
> On Tue, Dec 4, 2018 at 10:26 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> > +static int mlx5e_get_rss_hash_opt(struct mlx5e_priv *priv,
> > +                                 struct ethtool_rxnfc *nfc)
> ...
> > +       tt = flow_type_to_traffic_type(nfc->flow_type);
> > +
> > +       if (tt == MLX5E_NUM_INDIR_TIRS)
> > +               return -EINVAL;
> 
> The blank line above is unnecessary.
> 
> Thanks.

Sure will fix in V2,

Thank you Cong.