netdev - Re: [net-next 7/7] net/mlx5e: Improve ethtool private-flags code structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efab1abf25324827722fcb13ab3dcb5baeb476a9.camel@mellanox.com>
Date:   Wed, 5 Dec 2018 23:52:29 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net-next 7/7] net/mlx5e: Improve ethtool private-flags code
 structure

On Wed, 2018-12-05 at 10:36 -0800, Cong Wang wrote:
> On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > index a429553002a6..49e90ac5dc8b 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> ...
> >  #define MLX5E_SET_PFLAG(params, pflag, enable)                 \
> >         do {                                                    \
> >                 if (enable)                                     \
> > -                       (params)->pflags |= (pflag);            \
> > +                       (params)->pflags |= BIT(pflag);         \
> >                 else                                            \
> > -                       (params)->pflags &= ~(pflag);           \
> > +                       (params)->pflags &= ~(BIT(pflag));      \
> >         } while (0)
> > 
> 
> Please #include <linux/bits.h> explicitly.

Ok, will fix in V2

> 
> Thanks.