netdev - Re: [net-next 7/7] net/mlx5e: Improve ethtool private-flags code structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca9d778bc0466f41c0852ba02666439d815ae44f.camel@mellanox.com>
Date:   Wed, 5 Dec 2018 23:58:18 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net-next 7/7] net/mlx5e: Improve ethtool private-flags code
 structure

On Wed, 2018-12-05 at 11:28 -0800, Cong Wang wrote:
> Hello, Saeed
> 
> On Tue, Dec 4, 2018 at 10:27 PM Saeed Mahameed <saeedm@...lanox.com>
> wrote:
> >  static int mlx5e_handle_pflag(struct net_device *netdev,
> >                               u32 wanted_flags,
> > -                             enum mlx5e_priv_flag flag,
> > -                             mlx5e_pflag_handler pflag_handler)
> > +                             enum mlx5e_priv_flag flag)
> >  {
> ...
> >         if (err) {
> >                 netdev_err(netdev, "%s private flag 0x%x failed err
> > %d\n",
> >                            enable ? "Enable" : "Disable", flag,
> > err);
> 
> As flag is now a true enum, you probably don't want to print it out
> as hex
> any more.
> 

Good point, i guess we can print mlx5e_priv_flags[flag].name

thank you Cong !

> Thanks.