netdev - Re: [net-next PATCH RFC 1/8] page_pool: add helper functions for DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181207.230655.1261252486319967024.davem@davemloft.net>
Date:   Fri, 07 Dec 2018 23:06:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     netdev@...r.kernel.org, toke@...e.dk, ard.biesheuvel@...aro.org,
        jasowang@...hat.com, ilias.apalodimas@...aro.org,
        bjorn.topel@...el.com, w@....eu, saeedm@...lanox.com,
        mykyta.iziumtsev@...il.com, borkmann@...earbox.net,
        alexei.starovoitov@...il.com, tariqt@...lanox.com
Subject: Re: [net-next PATCH RFC 1/8] page_pool: add helper functions for
 DMA

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Fri, 07 Dec 2018 00:25:32 +0100

> From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> 
> Add helper functions for retreiving dma_addr_t stored in page_private and
> unmapping dma addresses, mapped via the page_pool API.
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

This isn't going to work on 32-bit platforms where dma_addr_t is a u64,
because the page private is unsigned long.

Grep for PHY_ADDR_T_64BIT under arch/ to see the vast majority of the
cases where this happens, then ARCH_DMA_ADDR_T_64BIT.