netdev - Re: [net-next PATCH RFC 4/8] net: core: add recycle capabilities on skbs via page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181208075432.GA1798@apalos>
Date:   Sat, 8 Dec 2018 09:54:32 +0200
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     David Miller <davem@...emloft.net>
Cc:     brouer@...hat.com, netdev@...r.kernel.org, toke@...e.dk,
        ard.biesheuvel@...aro.org, jasowang@...hat.com,
        bjorn.topel@...el.com, w@....eu, saeedm@...lanox.com,
        mykyta.iziumtsev@...il.com, borkmann@...earbox.net,
        alexei.starovoitov@...il.com, tariqt@...lanox.com
Subject: Re: [net-next PATCH RFC 4/8] net: core: add recycle capabilities on
 skbs via page_pool API

On Fri, Dec 07, 2018 at 11:15:14PM -0800, David Miller wrote:
> From: Jesper Dangaard Brouer <brouer@...hat.com>
> Date: Fri, 07 Dec 2018 00:25:47 +0100
> 
> > @@ -744,6 +745,10 @@ struct sk_buff {
> >  				head_frag:1,
> >  				xmit_more:1,
> >  				pfmemalloc:1;
> > +	/* TODO: Future idea, extend mem_info with __u8 flags, and
> > +	 * move bits head_frag and pfmemalloc there.
> > +	 */
> > +	struct xdp_mem_info	mem_info;
> 
> This is 4 bytes right?

With this patchset yes

> 
> I guess I can live with this.

Great news!

> 
> Please do some microbenchmarks to make sure this doesn't show any
> obvious regressions.

Will do

Thanks
/Ilias