netdev - Re: [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <447e828c-e639-4dd7-27df-5386e8c1df5b@denx.de>
Date:   Mon, 10 Dec 2018 14:27:25 +0100
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com,
        vivien.didelot@...oirfairelinux.com, Woojung.Huh@...rochip.com,
        UNGLinuxDriver@...rochip.com,
        Tristram Ha <Tristram.Ha@...rochip.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/5] net: dsa: ksz: Add MIB counter reading support

On 12/08/2018 12:16 PM, Andrew Lunn wrote:
>> +static void ksz9477_phy_setup(struct ksz_device *dev, int port,
>> +			      struct phy_device *phy)
>> +{
>> +	if (port < dev->phy_port_cnt) {
>> +		/* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to
>> +		 * disable flow control when rate limiting is used.
>> +		 */
>> +		phy->advertising = phy->supported;
>> +	}
>> +}
>> +
> 
> This has nothing to do with MIB counters.
> 
> Other than that, is this the same as Tristram's recent submission?
> Maybe once the comments have been addressed, we can merge that
> version?

I was not CCed on his recent submission, link ?

-- 
Best regards,
Marek Vasut