netdev - Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zhtdsd3w.fsf@miraculix.mork.no>
Date:   Mon, 10 Dec 2018 14:52:35 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Jörgen Storvist <jorgen.storvist@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series

Jörgen Storvist <jorgen.storvist@...il.com> writes:

> Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@...il.com>
>
> drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..820081e 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
>  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
>  	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
>  
>  	/* 4. Gobi 1000 devices */
>  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

Looks good, but could you please try to add it in a semi-numeric order?
Yes, I know it's far from perfect from before.  But I'm hoping to avoid
it growing worse ;-)


Bjørn