netdev - Re: [PATCH v2] qmi_wwan: Added support for Fibocom NL668 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 14:49:14 +0100
From:   Jörgen Storvist <jorgen.storvist@...il.com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] qmi_wwan: Added support for Fibocom NL668 series


Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.

Signed-off-by: Jörgen Storvist <jorgen.storvist@...il.com> 
---
Changes:
Changed list order to correpond to USB VID/PID values. 

drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 72a55b6..dada68f 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd181, 5)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd191, 4)},	/* Wistron NeWeb D19Q1 */
+	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
 	{QMI_FIXED_INTF(0x16d8, 0x6003, 0)},	/* CMOTech 6003 */
 	{QMI_FIXED_INTF(0x16d8, 0x6007, 0)},	/* CMOTech CHE-628S */
 	{QMI_FIXED_INTF(0x16d8, 0x6008, 0)},	/* CMOTech CMU-301 */

Thanks for the feedback Björn! 
Should be correct now as above if I understood you correctly.
//Jörgen

Den Mon, 10 Dec 2018 14:52:35 +0100
skrev Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series:

> Jörgen Storvist <jorgen.storvist@...il.com> writes:
> 
> > Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> > Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
> >
> > Signed-off-by: Jörgen Storvist <jorgen.storvist@...il.com>
> >
> > drivers/net/usb/qmi_wwan.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> > index 72a55b6..820081e 100644
> > --- a/drivers/net/usb/qmi_wwan.c
> > +++ b/drivers/net/usb/qmi_wwan.c
> > @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
> >  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
> >  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
> >  	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> > +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
> >  
> >  	/* 4. Gobi 1000 devices */
> >  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */  
> 
> Looks good, but could you please try to add it in a semi-numeric order?
> Yes, I know it's far from perfect from before.  But I'm hoping to avoid
> it growing worse ;-)
> 
> 
> Bjørn