netdev - Re: [PATCH v2 bpf-next 1/2] bpf: include sub program tags in bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BCF68AE3-4995-40FC-B26D-0BF56F90367C@fb.com>
Date:   Tue, 11 Dec 2018 17:08:54 +0000
From:   Song Liu <songliubraving@...com>
To:     Daniel Borkmann <daniel@...earbox.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "ast@...nel.org" <ast@...nel.org>,
        Kernel Team <Kernel-team@...com>, Martin Lau <kafai@...com>
Subject: Re: [PATCH v2 bpf-next 1/2] bpf: include sub program tags in
 bpf_prog_info



> On Dec 11, 2018, at 7:54 AM, Daniel Borkmann <daniel@...earbox.net> wrote:
> 
> On 12/11/2018 09:18 AM, Song Liu wrote:
>> Changes from v1:
>> 1. Fix error path as Martin suggested.
>> 
>> This patch adds nr_prog_tags and prog_tags to bpf_prog_info. This is a
>> reliable way for user space to get tags of all sub programs. Before this
>> patch, user space need to find sub program tags via kallsyms.
>> 
>> This feature will be used in BPF introspection, where user space queries
>> information about BPF programs via sys_bpf.
> 
> Should bpftool be updated as well to support this facility?
> 
> Thanks,
> Daniel

Currently, bpftool gets sub program tags from kallsyms (kernel_syms_load, 
kernel_syms_search). So it doesn't need this urgently. In longer term, 
we may replace kernel_syms_* functions with information from tag and BTF. 

Thanks,
Song