netdev - Re: [PATCH net-next] neighbor: Add protocol attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Dec 2018 19:47:33 -0700
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next] neighbor: Add protocol attribute

On 12/7/18 4:45 PM, David Miller wrote:
> 
> Right, neigh->ha[] should probably be kept 8-byte aligned.
> 

>From what I can see ha is only used with memcpy, and neighbour struct is
annotated with __randomize_layout. Are you saying that ha should be
marked with __aligned(8)?


@@ -150,7 +150,7 @@ struct neighbour {
        __u8                    type;
        __u8                    dead;
        seqlock_t               ha_lock;
-       unsigned char           ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned
long))];
+       unsigned char           ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned
long))] __aligned(8);
        struct hh_cache         hh;
        int                     (*output)(struct neighbour *, struct
sk_buff *);
        const struct neigh_ops  *ops;