netdev - Re: [PATCH net-next] neighbor: Add protocol attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181210.215937.1179843388675835344.davem@davemloft.net>
Date:   Mon, 10 Dec 2018 21:59:37 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     eric.dumazet@...il.com, netdev@...r.kernel.org,
        roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next] neighbor: Add protocol attribute

From: David Ahern <dsahern@...il.com>
Date: Mon, 10 Dec 2018 19:47:33 -0700

> On 12/7/18 4:45 PM, David Miller wrote:
>> 
>> Right, neigh->ha[] should probably be kept 8-byte aligned.
>> 
> 
> From what I can see ha is only used with memcpy, and neighbour struct is
> annotated with __randomize_layout. Are you saying that ha should be
> marked with __aligned(8)?

People who care about performance probably don't build with randomization
enabled, do they?

Even though it uses memcpy() it will be faster if it is 8 byte aligned
and we can probably explicitly take advantage of that alignment even
more if we add the marking as you suggest perhaps.

Given all of this, what is your opinion?