netdev - Re: [PATCH bpf-next 1/3] selftests: bpf: add trivial JSET test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd1ba986-5909-2729-9a92-5c8b8a3567df@iogearbox.net>
Date:   Thu, 13 Dec 2018 21:14:06 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     alexei.starovoitov@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next 1/3] selftests: bpf: add trivial JSET test

On 12/13/2018 07:52 PM, Jakub Kicinski wrote:
> On Thu, 13 Dec 2018 16:17:37 +0100, Daniel Borkmann wrote:
>> Could we rather extend the test_verifier infrastructure in order to
>> be able to define data input for bpf_prog_test_run()? I think this
>> would be very useful for future tests there as well and avoid having
>> to duplicate or split functionality into test_progs.c instead.
> 
> No strong feelings but if it's called test_verifier, and the sample puts
> no stress on the verifier it feels weird to put it there..  But okay, I
> will respin.. at some point :)

Well, test_verifier is running every program that passes the verifier
via bpf_prog_test_run() anyway to increase test coverage also for JIT
and runtime rather than just plain verification itself. In that sense
it includes testing what verifier has been rewritten, for example. I
just noticed we already have this feature via 93731ef086ce ("bpf:
migrate ebpf ld_abs/ld_ind tests to test_verifier"). ;-) So just adding
the test code there should suffice.