netdev - Re: [PATCH] vhost: correct the related warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 21:03:01 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     wangyan <wangyan122@...wei.com>
Cc:     jasowang@...hat.com, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        piaojun <piaojun@...wei.com>, hch@....de, viro@...iv.linux.org.uk
Subject: Re: [PATCH] vhost: correct the related warning message

On Thu, Dec 13, 2018 at 09:10:14AM +0800, wangyan wrote:
> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression + remove tf_subsystem")'
>        'commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends")'
> 
> Signed-off-by: Yan Wang <wangyan122@...wei.com>
> Reviewed-by: Jun Piao <piaojun@...wei.com>

Applied, thanks!

> ---
>  drivers/vhost/scsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 50dffe8..b459b69 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -889,7 +889,7 @@ static void vhost_scsi_submission_work(struct work_struct *work)
>  
>  	if (unlikely(!copy_from_iter_full(vc->req, vc->req_size,
>  					  &vc->out_iter))) {
> -		vq_err(vq, "Faulted on copy_from_iter\n");
> +		vq_err(vq, "Faulted on copy_from_iter_full\n");
>  	} else if (unlikely(*vc->lunp != 1)) {
>  		/* virtio-scsi spec requires byte 0 of the lun to be 1 */
>  		vq_err(vq, "Illegal virtio-scsi lun: %u\n", *vc->lunp);
> @@ -1441,7 +1441,7 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
>  			se_tpg = &tpg->se_tpg;
>  			ret = target_depend_item(&se_tpg->tpg_group.cg_item);
>  			if (ret) {
> -				pr_warn("configfs_depend_item() failed: %d\n", ret);
> +				pr_warn("target_depend_item() failed: %d\n", ret);
>  				kfree(vs_tpg);
>  				mutex_unlock(&tpg->tv_tpg_mutex);
>  				goto out;
> -- 
> 1.8.3.1
>