netdev - Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181214163843.GF26090@n2100.armlinux.org.uk>
Date:   Fri, 14 Dec 2018 16:38:43 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Antoine Tenart <antoine.tenart@...tlin.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
        maxime.chevallier@...tlin.com, gregory.clement@...tlin.com,
        miquel.raynal@...tlin.com, nadavh@...vell.com, stefanc@...vell.com,
        ymarkman@...vell.com, mw@...ihalf.com,
        Baruch Siach <baruch@...s.co.il>
Subject: Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all
 ports

On Fri, Dec 14, 2018 at 05:09:44PM +0100, Antoine Tenart wrote:
> Hi Russell,
> 
> On Fri, Dec 14, 2018 at 04:02:50PM +0000, Russell King - ARM Linux wrote:
> > On Fri, Dec 14, 2018 at 10:34:51AM +0100, Antoine Tenart wrote:
> > > The mvpp2_phylink_validate() function sets all modes that are
> > > supported by a given PPv2 port. A recent change made all ports to
> > > advertise they support 10G modes in certain cases. This is not true,
> > > as only the port #0 can do so. This patch fixes it.
> > > 
> > > Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules")
> > > Cc: Baruch Siach <baruch@...s.co.il>
> > > Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>
> > 
> > Looking at net-next, I think there's more to be fixed here:
> > 
> >         case PHY_INTERFACE_MODE_RGMII:
> >         case PHY_INTERFACE_MODE_RGMII_ID:
> >         case PHY_INTERFACE_MODE_RGMII_RXID:
> >         case PHY_INTERFACE_MODE_RGMII_TXID:
> >         case PHY_INTERFACE_MODE_SGMII:
> > ...
> > 		phylink_set(mask, 10000baseT_Full);
> > 
> > Is that really true?
> 
> Good catch. Will you send a fix or do you want me to do it?

I'm not planning to given that I don't know what other changes are
in the pipeline - I had assumed you'd wrap it up into a v3.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up