netdev - Re: [PATCH] test_rhashtable: remove semaphore usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181214.132551.1587998892072248943.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 13:25:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     tgraf@...g.ch, herbert@...dor.apana.org.au, neilb@...e.com,
        tom@...ntonium.net, keescook@...omium.org, paulb@...lanox.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] test_rhashtable: remove semaphore usage

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 10 Dec 2018 22:17:20 +0100

> @@ -635,8 +636,9 @@ static int threadfunc(void *data)
>  	int i, step, err = 0, insert_retries = 0;
>  	struct thread_data *tdata = data;
>  
> -	up(&prestart_sem);
> -	if (down_interruptible(&startup_sem))
> +	if (atomic_dec_and_test(&startup_count))
> +		wake_up(&startup_wait);
> +	if (wait_event_interruptible(startup_wait, atomic_read(&startup_count) == -1))
>  		pr_err("  thread[%d]: down_interruptible failed\n", tdata->id);

Arnd, please adjust this pr_err() text to match the new code as pointed out by
Phil Sutter.

Thank you.