netdev - Re: [Patch net] tipc: compare remote and local protocols in tipc_udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181214.132841.1255908718751546861.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 13:28:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, ying.xue@...driver.com,
        jon.maloy@...csson.com
Subject: Re: [Patch net] tipc: compare remote and local protocols in
 tipc_udp_enable()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Mon, 10 Dec 2018 15:23:30 -0800

> When TIPC_NLA_UDP_REMOTE is an IPv6 mcast address but
> TIPC_NLA_UDP_LOCAL is an IPv4 address, a NULL-ptr deref is triggered
> as the UDP tunnel sock is initialized to IPv4 or IPv6 sock merely
> based on the protocol in local address.
> 
> We should just error out when the remote address and local address
> have different protocols.
> 
> Reported-by: syzbot+eb4da3a20fad2e52555d@...kaller.appspotmail.com
> Cc: Ying Xue <ying.xue@...driver.com>
> Cc: Jon Maloy <jon.maloy@...csson.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.