netdev - Re: [PATCH net-next v2] tun: replace get_cpu_ptr with this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181214.133350.1458121392718567951.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 13:33:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     bhole_prashant_q7@....ntt.co.jp
Cc:     jasowang@...hat.com, mst@...hat.com, netdev@...r.kernel.org,
        makita.toshiaki@....ntt.co.jp
Subject: Re: [PATCH net-next v2] tun: replace get_cpu_ptr with this_cpu_ptr
 when bh disabled

From: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
Date: Tue, 11 Dec 2018 11:43:07 +0900

> tun_xdp_one() runs with local bh disabled. So there is no need to
> disable preemption by calling get_cpu_ptr while updating stats. This
> patch replaces the use of get_cpu_ptr() with this_cpu_ptr() as a
> micro-optimization. Also removes related put_cpu_ptr call.
> 
> Acked-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
> ---
> v1 -> v2: Added comment to explain why this change is safe

Applied, thanks.