netdev - Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181215195940.GF5922@lunn.ch>
Date:   Sat, 15 Dec 2018 20:59:40 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Marek Vasut <marex@...x.de>, netdev@...r.kernel.org,
        f.fainelli@...il.com
Subject: Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

> >> +static int tja11xx_config_init(struct phy_device *phydev)
> >> +{
> >> +	int ret;
> >> +
> >> +	ret = tja11xx_enable_reg_write(phydev);
> >> +	if (ret)
> >> +		return ret;
> >> +
> >> +	phydev->irq = PHY_POLL;
> >> +	phydev->autoneg = AUTONEG_DISABLE;
> >> +	phydev->speed = SPEED_100;
> 
> One more thing: In the data sheet there are SPEED_SELECT bits allowing
> to set also 10MBit and 1GBit mode. Don't you want to support this?

Hi Heiner

Did you read footnote 2?

Speed Select. 00: 10 Mbits; 01: 100Mbit/s, 10: 1000Mbit/s, 11:
reserved. a write access value other than 01 is ignored.

So the bits are there, but not really used. It can only do 100Mbit/s.

   Andrew