netdev - Re: [PATCH] ethtool: zero initialize coalesce struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181215022651.GJ21324@unicorn.suse.cz>
Date:   Sat, 15 Dec 2018 03:26:51 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     Maciej Żenczykowski <maze@...gle.com>,
        Jeff Garzik <jgarzik@...ox.com>,
        Ben Hutchings <ben@...adent.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        David Decotigny <decot@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct

On Fri, Dec 14, 2018 at 05:19:23PM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> prior to fetching it from kernel.
> 
> Otherwise we run the risk of very tail portion of it (dmac field)
> being left entirely uninitialized, and likely containing some sort
> of stale data.

The dmac member of struct ethtool_coalesce was removed by commit
c0b078ce7e88 ("Revert "ethtool: Add DMA Coalescing support"") because it
has never been added in kernel (as that would break compatibility with
older ethtool versions).

Michal Kubecek