netdev - Re: [PATCH] ethtool: zero initialize coalesce struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP3RGexaMYs76dxKnetfdXiXHFe306O7ZXjEvH-RNMJAn0sbw@mail.gmail.com>
Date:   Fri, 14 Dec 2018 18:30:36 -0800
From:   Maciej Żenczykowski <zenczykowski@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Jeff Garzik <jgarzik@...ox.com>,
        Ben Hutchings <ben@...adent.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        David Decotigny <decot@...gle.com>,
        Linux NetDev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct

> The dmac member of struct ethtool_coalesce was removed by commit
> c0b078ce7e88 ("Revert "ethtool: Add DMA Coalescing support"") because it
> has never been added in kernel (as that would break compatibility with
> older ethtool versions).

Hmm, well, it doesn't hurt to zero init either way...