netdev - Re: [PATCH] ethtool: zero initialize coalesce struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffd45c7b3d4462879b484e429791f4cf07f7fce9.camel@decadent.org.uk>
Date:   Sat, 15 Dec 2018 12:29:41 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Maciej Żenczykowski <zenczykowski@...il.com>,
        Maciej Żenczykowski <maze@...gle.com>,
        Jeff Garzik <jgarzik@...ox.com>,
        "John W. Linville" <linville@...driver.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        David Decotigny <decot@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct

I handed over ethtool to John Linville some time ago.

Ben.

On Fri, 2018-12-14 at 17:19 -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> prior to fetching it from kernel.
> 
> Otherwise we run the risk of very tail portion of it (dmac field)
> being left entirely uninitialized, and likely containing some sort
> of stale data.
> 
> It seems to likely be some sort of time (a second's counter).
> 
> Tested:
>   'ethtool -c eth1' with old kernel now reports 'dmac: 0' where
>   previously it reported some sort of second counter.
> 
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> ---
>  ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ethtool.c b/ethtool.c
> index 2f7e96bb58db..465eeecb9318 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -2076,7 +2076,7 @@ static int do_gchannels(struct cmd_context *ctx)
>  
>  static int do_gcoalesce(struct cmd_context *ctx)
>  {
> -	struct ethtool_coalesce ecoal;
> +	struct ethtool_coalesce ecoal = {};
>  	int err;
>  
>  	if (ctx->argc != 0)
-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)