netdev - Re: [PATCH] ethtool: change to new sane powerpc64 kernel headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5450d5f84ca3756aed31cfcf7eed0d7acbbbcd61.camel@decadent.org.uk>
Date:   Sat, 15 Dec 2018 12:30:11 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Maciej Żenczykowski <zenczykowski@...il.com>,
        Maciej Żenczykowski <maze@...gle.com>,
        Jeff Garzik <jgarzik@...ox.com>,
        "John W. Linville" <linville@...driver.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        David Decotigny <decot@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: change to new sane powerpc64 kernel headers

On Fri, 2018-12-14 at 17:19 -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> This fixes:
>   In file included from ethtool-copy.h:22:0,
>                    from internal.h:32,
>                    from ethtool.c:29:
>   .../include/linux/types.h:32:25: error: conflicting types for '__be64'
>    typedef __u64 __bitwise __be64;
>                            ^
>   In file included from ethtool.c:29:0:
>   internal.h:23:28: note: previous declaration of '__be64' was here
>    typedef unsigned long long __be64;
>                               ^
>   ethtool.c: In function 'do_gstats':
>   ethtool.c:3166:4: error: format '%llu' expects argument of type 'long long unsigned int', but argument 5 has type '__u64' [-Werror=format=]
>       stats->data[i]);
>       ^
>   ethtool.c: In function 'print_indir_table':
>   ethtool.c:3293:9: error: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type '__u64' [-Werror=format=]
>            ctx->devname, ring_count->data);
>            ^
> 
> $ gcc -dM -E - <<< "" | egrep -i 'power|ppc|arm|aarch|x86|86|amd'
> 
> .#define __x86_64 1
> .#define __amd64 1
> .#define __x86_64__ 1
> .#define __amd64__ 1
> 
> .#define _ARCH_PPCGR 1
> .#define __PPC64__ 1
> .#define _ARCH_PPC 1
> .#define __powerpc64__ 1
> .#define __PPC__ 1
> .#define __powerpc__ 1
> .#define _ARCH_PPC64 1
> 
> .#define __AARCH64_CMODEL_SMALL__ 1
> .#define __aarch64__ 1
> .#define __AARCH64EL__ 1
> .#define __ARM_NEON 1
> 
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> ---
>  ethtool-copy.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ethtool-copy.h b/ethtool-copy.h
> index 6bfbb85f9402..7772a4970987 100644
> --- a/ethtool-copy.h
> +++ b/ethtool-copy.h
> @@ -14,6 +14,12 @@
>  #ifndef _LINUX_ETHTOOL_H
>  #define _LINUX_ETHTOOL_H
>  
> +#ifdef __powerpc64__
> +/* Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select
> + * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu.
> + */
> +#define __SANE_USERSPACE_TYPES__
> +#endif
>  #include <linux/kernel.h>
>  #include <linux/types.h>
>  #include <linux/if_ether.h>
-- 
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)