netdev - Re: [PATCH] ethtool: zero initialize coalesce struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190118184002.GC30266@tuxdriver.com>
Date:   Fri, 18 Jan 2019 13:40:02 -0500
From:   "John W. Linville" <linville@...driver.com>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     Maciej Żenczykowski <maze@...gle.com>,
        Jeff Garzik <jgarzik@...ox.com>,
        Ben Hutchings <ben@...adent.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        David Decotigny <decot@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct

On Fri, Dec 14, 2018 at 05:19:23PM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> prior to fetching it from kernel.
> 
> Otherwise we run the risk of very tail portion of it (dmac field)
> being left entirely uninitialized, and likely containing some sort
> of stale data.
> 
> It seems to likely be some sort of time (a second's counter).
> 
> Tested:
>   'ethtool -c eth1' with old kernel now reports 'dmac: 0' where
>   previously it reported some sort of second counter.
> 
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>

Queued for next release.

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.