netdev - Re: [PATCH iproute2 2/4] testsuite: declare dependency between $(TESTS) and generate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181215162212.GA683@x230>
Date:   Sat, 15 Dec 2018 17:22:13 +0100
From:   Petr Vorel <petr.vorel@...il.com>
To:     Luca Boccassi <bluca@...ian.org>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        Petr Vorel <pvorel@...e.cz>
Subject: Re: [PATCH iproute2 2/4] testsuite: declare dependency between
 $(TESTS) and generate_nlmsg

Hi Luca,

> Parallel make from the top level directory fails since tests are at the
> same time as generate_nlmsg:

> $ make check -j4

> ...

> cd testsuite && make && make alltests
> echo "Entering iproute2" && cd iproute2 && make configure && cd ..;
> Entering iproute2
> make -C tools
> Removing results dir ...
> make[1]: ./tools/generate_nlmsg: Command not found
> make[1]: ./tools/generate_nlmsg: Command not found
> Makefile:64: recipe for target 'ip/netns/set_nsid_batch.t' failed
> make[1]: *** [ip/netns/set_nsid_batch.t] Error 127
> make[1]: ./tools/generate_nlmsg: Command not found
> make[1]: *** Waiting for unfinished jobs....
> Makefile:64: recipe for target 'ip/netns/set_nsid.t' failed
> make[1]: *** [ip/netns/set_nsid.t] Error 127
> Makefile:64: recipe for target 'ip/link/show_dev_wo_vf_rate.t' failed
> make[1]: *** [ip/link/show_dev_wo_vf_rate.t] Error 127
>     CC       generate_nlmsg
> Makefile:123: recipe for target 'check' failed
> make: *** [check] Error 2

> Add an explicit dependency in testuite/Makefile's $(TESTS) rule so
> that the tool correctly gets compiled before any test runs.

> Fixes: 3537633dcf44 ("testsuite: Generate generate_nlmsg when needed")
> Cc: petr.vorel@...il.com

> Signed-off-by: Luca Boccassi <bluca@...ian.org>
Reviewed-by: Petr Vorel <petr.vorel@...il.com>
Tested-by: Petr Vorel <petr.vorel@...il.com>

Again, thanks for fix.


Kind regards,
Petr