netdev - Re: [PATCH iproute2 3/4] tests: delete dummy interface after default route test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181215163250.GA29950@x230>
Date:   Sat, 15 Dec 2018 17:32:50 +0100
From:   Petr Vorel <pvorel@...e.cz>
To:     Luca Boccassi <bluca@...ian.org>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2 3/4] tests: delete dummy interface after default
 route test

Hi Luca,

> Signed-off-by: Luca Boccassi <bluca@...ian.org>
Reviewed-by: Petr Vorel <pvorel@...e.cz>
> ---
>  testsuite/tests/ip/route/add_default_route.t | 2 ++
>  1 file changed, 2 insertions(+)

> diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_default_route.t
> index 569ba1f8..c536e35f 100755
> --- a/testsuite/tests/ip/route/add_default_route.t
> +++ b/testsuite/tests/ip/route/add_default_route.t
> @@ -31,3 +31,5 @@ ts_ip "$0" "Add another IPv6 route dst cafe:babe::/64" -6 route add cafe:babe::/
>  ts_ip "$0" "Show IPv6 default route" -6 route show default
>  test_on "default via dead:beef::2 dev $DEV"
>  test_lines_count 1
> +
> +ts_ip "$0" "Del $NEW_DEV dummy interface"  link del dev $DEV
Shouldn't this be using $DEV instead of $NEW_DEV?
ts_ip "$0" "Delete $DEV interface" link del dev $DEV

Copy paste from new_link.t?

Kind regards,
Petr