netdev - Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d95d35af-01bf-315c-1017-f1f8c4480b29@gmail.com>
Date:   Sun, 16 Dec 2018 23:22:53 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Peter Oskolkov <posk.devel@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Peter Oskolkov <posk@...gle.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        syzbot <syzkaller@...glegroups.com>,
        Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening
 hashtable



On 12/16/2018 10:49 PM, Peter Oskolkov wrote:
 
> Actually, no: the earlier patch has this condition:
> 
> +       if (ilb->count <= 10 || !hashinfo->lhash2)
> +               goto port_lookup;
> 
> that checks if lhash2 is initialized. So the bug is in my patch.

Great, thanks for double checking.