netdev - Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181217.231227.297306724844808281.davem@davemloft.net>
Date:   Mon, 17 Dec 2018 23:12:27 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     posk@...gle.com
Cc:     netdev@...r.kernel.org, posk.devel@...il.com, edumazet@...gle.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net-next v2] net: dccp: initialize (addr,port)
 listening hashtable

From: Peter Oskolkov <posk@...gle.com>
Date: Sun, 16 Dec 2018 15:42:48 -0800

> Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address"
> removes port-only listener lookups. This caused segfaults in DCCP
> lookups because DCCP did not initialize the (addr,port) hashtable.
> 
> This patch adds said initialization.
> 
> The only non-trivial issue here is the size of the new hashtable.
> It seemed reasonable to make it match the size of the port-only
> hashtable (= INET_LHTABLE_SIZE) that was used previously. Other
> parameters to inet_hashinfo2_init() match those used in TCP.
> 
> V2 changes: marked inet_hashinfo2_init as an exported symbol
> so that DCCP compiles when configured as a module.
> 
> Tested: syzcaller issues fixed; the second patch in the patchset
>         tests that DCCP lookups work correctly.
> 
> Fixes: d9fbc7f6431f "net: tcp: prefer listeners bound to an address"
> Reported-by: syzcaller <syzkaller@...glegroups.com>
> Signed-off-by: Peter Oskolkov <posk@...gle.com>

Applied, thanks.