netdev - Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538b1829-422a-bf15-b024-e0bf933c930a@gmail.com>
Date:   Wed, 19 Dec 2018 10:26:43 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Rob Herring <robh@...nel.org>
Cc:     Woojung.Huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        Andrew Lunn <andrew@...n.ch>,
        vivien.didelot@...oirfairelinux.com,
        driverdev-devel@...uxdriverproject.org, davem@...emloft.net,
        netdev@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of
 switch bindings managed in i2c mode

On 12/18/18 10:23 PM, Sergio Paracuellos wrote:
> Hi Rob,
> 
> On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@...nel.org> wrote:
>>
>> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
>>> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>>>
>>> Cc: devicetree@...r.kernel.org
>>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
>>> ---
>>> Changes v3:
>>>     - No changes. Just resent patches together.
>>>
>>> Changes v2:
>>>     - Use generic name for label of the switch and make sure reg and @X
>>>       have the same value.
>>>
>>>  .../devicetree/bindings/net/dsa/ksz.txt       | 50 +++++++++++++++++++
>>>  1 file changed, 50 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> index 0f407fb371ce..d3c4b9d4f416 100644
>>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
>>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
>>>                                                               };
>>>                                               };
>>>                               };
>>> +
>>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
>>> +
>>> +                             eth0: ethernet@...01000 {
>>
>> Why do we have all this indentation? Please remove. And use tab chars,
>> not spaces.
> 
> The original file format is using all of this indentation. So I think
> we would need a patch to change de format of the original file and
> another with this new changes properly formatted.

The original formatting should be fixed, but your changes should adopt
the correct style from the first time they are submitted. Do you mind
resubmitting with only one tab? We can fix the original examples as a
follow-up patch.

Thanks!
-- 
Florian