netdev - Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs-H8LMLquPEBa4w84OTWOdZGJwAaoMV9=psN2hNR+oeO46Q@mail.gmail.com>
Date:   Wed, 19 Dec 2018 20:49:19 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Rob Herring <robh@...nel.org>, Woojung.Huh@...rochip.com,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        vivien.didelot@...oirfairelinux.com,
        driverdev-devel@...uxdriverproject.org, davem@...emloft.net,
        netdev@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of
 switch bindings managed in i2c mode

On Wed, Dec 19, 2018 at 7:26 PM Florian Fainelli <f.fainelli@...il.com> wrote:
>
> On 12/18/18 10:23 PM, Sergio Paracuellos wrote:
> > Hi Rob,
> >
> > On Tue, Dec 18, 2018 at 4:10 PM Rob Herring <robh@...nel.org> wrote:
> >>
> >> On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote:
> >>> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >>>
> >>> Cc: devicetree@...r.kernel.org
> >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
> >>> ---
> >>> Changes v3:
> >>>     - No changes. Just resent patches together.
> >>>
> >>> Changes v2:
> >>>     - Use generic name for label of the switch and make sure reg and @X
> >>>       have the same value.
> >>>
> >>>  .../devicetree/bindings/net/dsa/ksz.txt       | 50 +++++++++++++++++++
> >>>  1 file changed, 50 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> index 0f407fb371ce..d3c4b9d4f416 100644
> >>> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> >>> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> >>>                                                               };
> >>>                                               };
> >>>                               };
> >>> +
> >>> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> >>> +
> >>> +                             eth0: ethernet@...01000 {
> >>
> >> Why do we have all this indentation? Please remove. And use tab chars,
> >> not spaces.
> >
> > The original file format is using all of this indentation. So I think
> > we would need a patch to change de format of the original file and
> > another with this new changes properly formatted.
>
> The original formatting should be fixed, but your changes should adopt
> the correct style from the first time they are submitted. Do you mind
> resubmitting with only one tab? We can fix the original examples as a
> follow-up patch.

I see. Thanks for let me know. I'll be more careful from now.

v4 actually sent with changes proposed here.

>
> Thanks!
> --
> Florian

Best regards,
    Sergio Paracuellos