netdev - Re: [PATCH net] gro_cell: add napi_disable in gro_cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL0HQ22P_Pv1SG-uC9ZA0b_qZ6Emj6+b3SXtNnjKToDbA@mail.gmail.com>
Date:   Wed, 19 Dec 2018 14:46:12 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] gro_cell: add napi_disable in gro_cells_destroy

On Wed, Dec 19, 2018 at 2:23 PM Lorenzo Bianconi
<lorenzo.bianconi@...hat.com> wrote:
>
> Add napi_disable routine in gro_cells_destroy since starting from
> commit c42858eaf492 ("gro_cells: remove spinlock protecting receive
> queues") gro_cell_poll and gro_cells_destroy can run concurrently on
> napi_skbs list producing a kernel Oops if the tunnel interface is
> removed while gro_cell_poll is running. The following Oops has been
> triggered removing a vxlan device while the interface is receiving
> traffic
>

This seems reasonable, I wonder why this bug has been hiding for so long...

Acked-by: Eric Dumazet <edumazet@...gle.com>