netdev - Re: [PATCH net] gro_cell: add napi_disable in gro_cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181219.155100.1168332357103502747.davem@davemloft.net>
Date:   Wed, 19 Dec 2018 15:51:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net] gro_cell: add napi_disable in gro_cells_destroy

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Wed, 19 Dec 2018 23:23:00 +0100

> Add napi_disable routine in gro_cells_destroy since starting from
> commit c42858eaf492 ("gro_cells: remove spinlock protecting receive
> queues") gro_cell_poll and gro_cells_destroy can run concurrently on
> napi_skbs list producing a kernel Oops if the tunnel interface is
> removed while gro_cell_poll is running. The following Oops has been
> triggered removing a vxlan device while the interface is receiving
> traffic
 ...
> Fixes: c42858eaf492 ("gro_cells: remove spinlock protecting receive queues")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>

Applied and queued up for -stable, thanks.