netdev - Re: [PATCH net] mscc: Register poll timeout should be wall time not attempts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181220103150.GD13180@lunn.ch>
Date:   Thu, 20 Dec 2018 11:31:50 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Steen Hegelund <steen.hegelund@...rochip.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        alexandre.belloni@...tlin.com
Subject: Re: [PATCH net] mscc: Register poll timeout should be wall time not
 attempts

On Thu, Dec 20, 2018 at 10:08:16AM +0100, Steen Hegelund wrote:
> When doing indirect access in the Ocelot chip, a command is setup,
> issued and then we need to poll until the result is ready. The polling
> timeout is specified in milliseconds in the datasheet and not in
> register access attempts.
> 
> Signed-off-by: Steen Hegelund <steen.hegelund@...rochip.com>

Hi Steen

Have you seen real issues with this code? You have marked this for
net, indicating it is a bug fix. If it is a real fix, please provide a
fixes: tag.

Thanks
	Andrew