netdev - Re: [PATCH net-next 0/2] net: phy: make PHY_HALTED a transition state to PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181220.191130.1835798991347612480.davem@davemloft.net>
Date:   Thu, 20 Dec 2018 19:11:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] net: phy: make PHY_HALTED a transition
 state to PHY_READY

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 19 Dec 2018 07:50:43 +0100

> PHY_HALTED and PHY_READY both are non-started states and quite similar.
> Major difference is that phy_start() changes from PHY_HALTED to
> PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does).
> 
> There's no guarantee that PHY registers are completely untouched when
> waking up from power-down, e.g. after system suspend. Therefore it's
> safer to reconfigure aneg also when starting from PHY_HALTED. This can
> be achieved and state machine made simpler by making PHY_HALTED going
> to PHY_READY after having stopped everything. Then the only way up is
> over PHY_UP. As part of the change PHY_HALTED is renamed to PHY_HALT to
> reflect that it is a transition state.
> 
> After this change states PHY_RESUMING and PHY_CHANGELINK can be
> removed.

Patch #1 is under discussion still with any clear resolution, and the
net-next tree is closing tonight, so I'm marking this as deferred.