netdev - Re: [PATCH 1/1] net-next/hinic:add shutdown callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181228.214905.2208487974538707696.davem@davemloft.net>
Date:   Fri, 28 Dec 2018 21:49:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xuechaojing@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        wulike1@...wei.com, chiqijun@...wei.com, fy.wang@...wei.com,
        tony.qu@...wei.com, luoshaokai@...wei.com
Subject: Re: [PATCH 1/1] net-next/hinic:add shutdown callback

From: Xue Chaojing <xuechaojing@...wei.com>
Date: Fri, 28 Dec 2018 00:20:40 +0000

> @@ -1106,6 +1106,13 @@ static void hinic_remove(struct pci_dev *pdev)
>  	dev_info(&pdev->dev, "HiNIC driver - removed\n");
>  }
>  
> +static void hinic_shutdown(struct pci_dev *pdev)
> +{
> +	pci_disable_device(pdev);
> +
> +	dev_info(&pdev->dev, "HiNIC driver - shutdown\n");
> +}

I do not think these messages are appropriate.  I didn't catch
them before, but I'm not going to let new ones get added.