netdev - 答复: [PATCH 1/1] net-next/hinic:add shutdown callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DACA750462785649825D7529120E85A808A8320D@dggemm521-mbs.china.huawei.com>
Date:   Sat, 29 Dec 2018 09:20:54 +0000
From:   xuechaojing <xuechaojing@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "wulike (A)" <wulike1@...wei.com>, chiqijun <chiqijun@...wei.com>,
        Wangfengying <fy.wang@...wei.com>,
        "Quhuichun (Tony)" <tony.qu@...wei.com>,
        "Luoshaokai (luoshaokai)" <luoshaokai@...wei.com>
Subject: 答复: [PATCH 1/1] net-next/hinic:add shutdown callback

HI:

Sorry, I didn't explain this patch clearly.
if there is no shutdown callback, our board will report pcie UNF errors after restarting.
Attached is our log.

Xuechaojing
-----邮件原件-----
发件人: David Miller [mailto:davem@...emloft.net] 
发送时间: 2018年12月29日 13:49
收件人: xuechaojing <xuechaojing@...wei.com>
抄送: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; wulike (A) <wulike1@...wei.com>; chiqijun <chiqijun@...wei.com>; Wangfengying <fy.wang@...wei.com>; Quhuichun (Tony) <tony.qu@...wei.com>; Luoshaokai (luoshaokai) <luoshaokai@...wei.com>
主题: Re: [PATCH 1/1] net-next/hinic:add shutdown callback

From: Xue Chaojing <xuechaojing@...wei.com>
Date: Fri, 28 Dec 2018 00:20:40 +0000

> @@ -1106,6 +1106,13 @@ static void hinic_remove(struct pci_dev *pdev)
>  	dev_info(&pdev->dev, "HiNIC driver - removed\n");  }
>  
> +static void hinic_shutdown(struct pci_dev *pdev) {
> +	pci_disable_device(pdev);
> +
> +	dev_info(&pdev->dev, "HiNIC driver - shutdown\n"); }

I do not think these messages are appropriate.  I didn't catch them before, but I'm not going to let new ones get added.

Download attachment "20180731041827typescript-reboot" of type "application/octet-stream" (292061 bytes)