netdev - Re: [Patch net] net/wan: fix a double free in x25_asy_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Dec 2018 20:23:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [Patch net] net/wan: fix a double free in x25_asy_open_tty()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Sat, 29 Dec 2018 13:56:37 -0800

> When x25_asy_open() fails, it already cleans up by itself,
> so its caller doesn't need to free the memory again.
> 
> It seems we still have to call x25_asy_free() to clear the SLF_INUSE
> bit, so just set these pointers to NULL after kfree().
> 
> Reported-and-tested-by: syzbot+5e5e969e525129229052@...kaller.appspotmail.com
> Fixes: 3b780bed3138 ("x25_asy: Free x25_asy on x25_asy_open() failure.")
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks Cong.