netdev - Re: [Patch net] netrom: fix locking in nr_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181230.202459.1666665500046620349.davem@davemloft.net>
Date:   Sun, 30 Dec 2018 20:24:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [Patch net] netrom: fix locking in nr_find_socket()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Sat, 29 Dec 2018 13:56:38 -0800

> nr_find_socket(), nr_find_peer() and nr_find_listener() lock the
> sock after finding it in the global list. However, the call path
> requires BH disabled for the sock lock consistently.
> 
> Actually the locking is unnecessary at this point, we can just hold
> the sock refcnt to make sure it is not gone after we unlock the global
> list, and lock it later only when needed.
> 
> Reported-and-tested-by: syzbot+f621cda8b7e598908efa@...kaller.appspotmail.com
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable.