netdev - Re: [PATCH net] r8169: fix WoL device wakeup enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 30 Dec 2018 20:26:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] r8169: fix WoL device wakeup enable

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 30 Dec 2018 13:16:12 +0100

> In rtl8169_runtime_resume() we configure WoL but don't set the device
> to wakeup-enabled. This prevents PME generation once the cable is
> re-plugged. Fix this by moving the call to device_set_wakeup_enable()
> to __rtl8169_set_wol().
> 
> Fixes: 433f9d0ddcc6 ("r8169: improve saved_wolopts handling")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied, thanks Heiner.