netdev - Re: ixgbe / mdio dependancy error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44bb3689-d74e-cac4-c5b9-ce1f1545e77e@silicom-usa.com>
Date:   Wed, 2 Jan 2019 23:30:34 +0000
From:   Steve Douthit <stephend@...icom-usa.com>
To:     "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        Dave Jones <davej@...emonkey.org.uk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: ixgbe / mdio dependancy error

> This is because PHYLIB=m which forces MDIO_BUS=m.  If you have IXGBE=y,
> then PHYLIB and MDIO_BUS can't be modules.  Working on a patch to
> correct the issue.

There was a review comment to select MDIO_DEVICE instead of PHYLIB.
PHYLIB seems correct to me now that I'm looking at this again though.  I
came up empty looking for any other drivers that select MDIO_DEVICE.

The objection was that DSA devices wouldn't need the PHYLIB API, so why
force it to be built-in.  NET_DSA selects PHYLINK which selects PHYLIB.
I think we're ok going back to select PHYLIB if that was the only
problem.