netdev - Re: ixgbe / mdio dependancy error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3884b6a0af413948f6a06c95658a04c94674e9f6.camel@intel.com>
Date:   Wed, 02 Jan 2019 15:38:23 -0800
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Steve Douthit <stephend@...icom-usa.com>,
        Dave Jones <davej@...emonkey.org.uk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: ixgbe / mdio dependancy error

On Wed, 2019-01-02 at 23:30 +0000, Steve Douthit wrote:
> > This is because PHYLIB=m which forces MDIO_BUS=m.  If you have
> > IXGBE=y,
> > then PHYLIB and MDIO_BUS can't be modules.  Working on a patch to
> > correct the issue.
> 
> There was a review comment to select MDIO_DEVICE instead of PHYLIB.
> PHYLIB seems correct to me now that I'm looking at this again
> though.  I
> came up empty looking for any other drivers that select MDIO_DEVICE.
> 
> The objection was that DSA devices wouldn't need the PHYLIB API, so
> why
> force it to be built-in.  NET_DSA selects PHYLINK which selects
> PHYLIB.
> I think we're ok going back to select PHYLIB if that was the only
> problem.

Unfortunately, we get into a recursive dependency issue when IPSec gets
involved, and IPSec is enabled by default.

I am looking at making MDIO_BUS support for ixgbe an option like IPSec,
DCB, DCA and HWMON.  Where a user can select the option to have
MDIO_BUS support for DSA devices, that way we can add the requirement
that it requires !(IXGBE=y && MDIO_BUS=m).

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)