netdev - Re: [PATCH] net: sfc: checks status of efx_mcdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59347b7d-3b71-348a-9fba-c8a4cc73af3f@solarflare.com>
Date:   Wed, 2 Jan 2019 09:26:04 +0000
From:   Bert Kenward <bkenward@...arflare.com>
To:     Kangjie Lu <kjlu@....edu>
CC:     <pakki001@....edu>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Edward Cree <ecree@...arflare.com>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: sfc: checks status of efx_mcdi_rpc

Hello,

On 26/12/18 05:05, Kangjie Lu wrote:
> efx_mcdi_rpc() could fail. The fix checks its status and issues an error
> message if it fails.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
>  drivers/net/ethernet/sfc/mcdi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c
> index dfad93fca0a6..9486e6534dea 100644
> --- a/drivers/net/ethernet/sfc/mcdi.c
> +++ b/drivers/net/ethernet/sfc/mcdi.c
> @@ -1819,6 +1819,9 @@ void efx_mcdi_set_id_led(struct efx_nic *efx, enum efx_led_mode mode)
>  
>  	rc = efx_mcdi_rpc(efx, MC_CMD_SET_ID_LED, inbuf, sizeof(inbuf),
>  			  NULL, 0, NULL);
> +	if (rc)
> +		netif_err(efx, hw, efx->net_dev, "%s: failed rc=%d\n",
> +				__func__, rc);
>  }

efx_mcdi_rpc() already issues an error message on failure, so this doesn't add
anything beyond that.

Are you trying to address a particular issue with this patch?

Thanks,

Bert.