netdev - Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 03 Jan 2019 13:42:20 -0800
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     intel-wired-lan@...ts.osuosl.org
Cc:     netdev@...r.kernel.org, Dave Jones <davej@...emonkey.org.uk>,
        Steve Douthit <stephend@...icom-usa.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

On Thu, 2019-01-03 at 13:35 -0800, Jeff Kirsher wrote:
> The new ability added to the driver to use mii_bus to handle MII
> related
> ioctls is causing compile issues when the driver is compiled into the
> kernel (i.e. not a module).
> 
> The simple solution of requiring the driver to be compiled as a
> module when
> MDIO_BUS is a module, causes a recursion Kconfig issue due to IPSec
> dependencies.
> 
> So created another Kconfig option for ixgbe, to enable mdio_bus
> support for
> DSA devices.  This solution solves the problem when the ixgbe driver
> is
> compiled into the kernel and MDIO_BUS is compiled as a module.  In
> this
> case, the IXGBE_MDIO option is disabled and the code is not compiled
> into the driver.
> 
> CC: Dave Jones <davej@...emonkey.org.uk>
> CC: Steve Douthit <stephend@...icom-usa.com>
> CC: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/Kconfig            | 11 ++++++++++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  4 ++++
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 ++++++++++--
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  |  4 ++++
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h  |  3 ++-
>  5 files changed, 30 insertions(+), 4 deletions(-)

I have done the following compile tests to comfirm this resolves the
issue:

Kconfig:     1   2   3   4
--------    --- --- --- ---
ixgbe        m   m   y   y
 ixgbe_mdio  y   n   y   y
mdio_bus     m   m   m   y
phylib       m   m   m   y

Test #3 resulted in ixgbe_mdio being disabled and code not compiled
into the driver.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)