netdev - RE: [Intel-wired-lan] [PATCH] ixgbe: fix Kconfig when driver is not a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jan 2019 23:57:37 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Dave Jones <davej@...emonkey.org.uk>
Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: fix Kconfig when driver is not
 a module

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...osl.org] On
> Behalf Of Jeff Kirsher
> Sent: Thursday, January 3, 2019 1:35 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Florian Fainelli <f.fainelli@...il.com>; Dave
> Jones <davej@...emonkey.org.uk>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: fix Kconfig when driver is not a
> module
> 
> The new ability added to the driver to use mii_bus to handle MII related
> ioctls is causing compile issues when the driver is compiled into the kernel
> (i.e. not a module).
> 
> The simple solution of requiring the driver to be compiled as a module when
> MDIO_BUS is a module, causes a recursion Kconfig issue due to IPSec
> dependencies.
> 
> So created another Kconfig option for ixgbe, to enable mdio_bus support for
> DSA devices.  This solution solves the problem when the ixgbe driver is
> compiled into the kernel and MDIO_BUS is compiled as a module.  In this
> case, the IXGBE_MDIO option is disabled and the code is not compiled into
> the driver.
> 
> CC: Dave Jones <davej@...emonkey.org.uk>
> CC: Steve Douthit <stephend@...icom-usa.com>
> CC: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/Kconfig            | 11 ++++++++++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      |  4 ++++
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 ++++++++++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c  |  4 ++++
> drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h  |  3 ++-
>  5 files changed, 30 insertions(+), 4 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>